From 9ebf400a1c21117ff40cb78f0b023bf1cb4e9f6c Mon Sep 17 00:00:00 2001 From: Denis Ovsienko Date: Thu, 27 Oct 2011 20:04:08 +0400 Subject: bgpd: fix AS4_PATH attr flag check (BZ#676) AS_PATH is a well-known, transitive path attribute and cannot be flagged as "Partial". This is what commit 77a20b8af32c926176f8492a086d9e4ec670496b implemented, but it did not account, that bgp_attr_aspath() is also used to process AS4_PATH, which is an optional, transitive path attribute and as such may be flagged as "Partial". This change justfies the test condition. --- bgpd/bgp_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c index 4967e09a..2205e267 100644 --- a/bgpd/bgp_attr.c +++ b/bgpd/bgp_attr.c @@ -826,7 +826,7 @@ bgp_attr_aspath (struct peer *peer, bgp_size_t length, total = length + (CHECK_FLAG (flag, BGP_ATTR_FLAG_EXTLEN) ? 4 : 3); /* Check the attribute flags */ - if (CHECK_FLAG (flag, BGP_ATTR_FLAG_PARTIAL)) + if (!as4_path && CHECK_FLAG (flag, BGP_ATTR_FLAG_PARTIAL)) { zlog (peer->log, LOG_ERR, "AS_PATH attribute must not be flagged as \"partial\" (%u)", flag); -- cgit v1.2.1