From a5c851c7ff41ef846e83d62394176ac1753ebf45 Mon Sep 17 00:00:00 2001 From: David Lamparter Date: Tue, 27 Nov 2012 03:21:44 +0100 Subject: lib: remove ALL_LIST_ELEMENTS dead code branch ALL_LIST_ELEMENTS is checking node == NULL twice, which is causing a whole slew of false positives in Coverity. In this particular case, addressing this in the code is reasonable; being a macro, this appears all over the place without easy remedy. Acked-by: Scott Feldman Signed-off-by: David Lamparter --- lib/linklist.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/linklist.h b/lib/linklist.h index f0ae3625..24a9e206 100644 --- a/lib/linklist.h +++ b/lib/linklist.h @@ -90,7 +90,7 @@ extern void list_add_list (struct list *, struct list *); #define ALL_LIST_ELEMENTS(list,node,nextnode,data) \ (node) = listhead(list), ((data) = NULL); \ (node) != NULL && \ - ((data) = listgetdata(node),(nextnode) = listnextnode(node), 1); \ + ((data) = listgetdata(node),(nextnode) = node->next, 1); \ (node) = (nextnode), ((data) = NULL) /* read-only list iteration macro. -- cgit v1.2.1