From d2519962b71b512eb5fd55a378f8ef748d17c30f Mon Sep 17 00:00:00 2001 From: Paul Jakma Date: Fri, 12 May 2006 23:19:37 +0000 Subject: [lib] CID #37, fix error case leak, cmd_complete_command_real 2006-05-12 Paul Jakma * command.c: (cmd_complete_command_real) Fix leak of cmd_vector in error case, Coverity CID #37. --- lib/ChangeLog | 2 ++ lib/command.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/ChangeLog b/lib/ChangeLog index 64fa8518..dc9999b3 100644 --- a/lib/ChangeLog +++ b/lib/ChangeLog @@ -2,6 +2,8 @@ * plist.c: (vty_prefix_list_uninstall) Fix potential NULL deref of prefix and typestr strings, Coverity CID #3. + * command.c: (cmd_complete_command_real) Fix leak of cmd_vector + in error case, Coverity CID #37. 2006-03-30 Paul Jakma diff --git a/lib/command.c b/lib/command.c index ac3516c3..1c277b38 100644 --- a/lib/command.c +++ b/lib/command.c @@ -1,5 +1,5 @@ /* - $Id: command.c,v 1.51 2005/10/26 05:49:54 paul Exp $ + $Id: command.c,v 1.52 2006/05/12 23:19:37 paul Exp $ Command interpreter routine for virtual terminal [aka TeletYpe] Copyright (C) 1997, 98, 99 Kunihiro Ishiguro @@ -1785,6 +1785,7 @@ cmd_complete_command_real (vector vline, struct vty *vty, int *status) if (vector_active (vline) == 0) { + vector_free (cmd_vector); *status = CMD_ERR_NO_MATCH; return NULL; } -- cgit v1.2.1