From 9eda90ce8094683a5315007fbd0f9249a284f36f Mon Sep 17 00:00:00 2001 From: Paul Jakma Date: Thu, 30 Aug 2007 13:36:17 +0000 Subject: [bgpd] bug #398 Bogus free on out route-map, and assert() with rsclients 2007-08-27 Paul Jakma * bgp_route.c: (bgp_announce_check) Fix bug #398, slight modification of Vladimir Ivanov's suggested fix - to keep memory alloc conditional. (bgp_process_announce_selected) Don't take struct attr as argument, none of the callers need it and it needlessly distances allocation from use. Free the extended attr, the attr itself is on the stack. Fix bad indentation. * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert, and adjust conditional to test attr->extra, diagnosis by Vladimir Ivanov in bug #398. 2007-08-27 Vladimir Ivanov * bgp_route.c: (bgp_announce_check_rsclient) copy of ri->attr is no longer deep enough, due to addition of attr->extra. It should use bgp_attr_dup, as bgp_announce_check() does. --- bgpd/ChangeLog | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) (limited to 'bgpd/ChangeLog') diff --git a/bgpd/ChangeLog b/bgpd/ChangeLog index 548fd4d6..1cf5515b 100644 --- a/bgpd/ChangeLog +++ b/bgpd/ChangeLog @@ -1,3 +1,24 @@ +2007-08-27 Paul Jakma + + * bgp_route.c: (bgp_announce_check) Fix bug #398, slight + modification of Vladimir Ivanov's suggested fix - to keep + memory alloc conditional. + (bgp_process_announce_selected) Don't take struct attr as + argument, none of the callers need it and it needlessly + distances allocation from use. + Free the extended attr, the attr itself is on the stack. + Fix bad indentation. + * bgp_attr.c: (bgp_packet_attribute) Remove incorrect assert, + and adjust conditional to test attr->extra, diagnosis by + Vladimir Ivanov in bug #398. + +2007-08-27 Vladimir Ivanov + + * bgp_route.c: (bgp_announce_check_rsclient) copy of + ri->attr is no longer deep enough, due to addition of + attr->extra. It should use bgp_attr_dup, as + bgp_announce_check() does. + 2007-08-23 Paul Jakma * bgp_regex.c: (bgp_regcomp) Pass NOSUB flag to regcomp to -- cgit v1.2.1