From 93c1749c828cf750fbcc850730b9f2a872e38325 Mon Sep 17 00:00:00 2001 From: "Andrew J. Schorr" Date: Sun, 15 Apr 2007 19:17:24 +0000 Subject: [bgpd] Minor performance improvement patch 2007-04-15 Sebastien Tandel * bgp_aspath.c: (aspath_as_add, aspath_segment_add) Minor performance optimization: while loop should test one pointer instead of two. --- bgpd/bgp_aspath.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'bgpd/bgp_aspath.c') diff --git a/bgpd/bgp_aspath.c b/bgpd/bgp_aspath.c index 327406fa..1f522d79 100644 --- a/bgpd/bgp_aspath.c +++ b/bgpd/bgp_aspath.c @@ -1243,13 +1243,13 @@ aspath_as_add (struct aspath *as, as_t asno) { struct assegment *seg = as->segments; - /* Last segment search procedure. */ - while (seg && seg->next) - seg = seg->next; - if (!seg) return; + /* Last segment search procedure. */ + while (seg->next) + seg = seg->next; + assegment_append_asns (seg, &asno, 1); } @@ -1260,13 +1260,14 @@ aspath_segment_add (struct aspath *as, int type) struct assegment *seg = as->segments; struct assegment *new = assegment_new (type, 0); - while (seg && seg->next) - seg = seg->next; - - if (seg == NULL) - as->segments = new; + if (seg) + { + while (seg->next) + seg = seg->next; + seg->next = new; + } else - seg->next = new; + as->segments = new; } struct aspath * -- cgit v1.2.1