From 3b424979f54c6b128d1ee8a7c33d072d321f2f0c Mon Sep 17 00:00:00 2001 From: paul Date: Mon, 13 Oct 2003 09:47:32 +0000 Subject: 2003-10-13 Jay Fenlason * lib/zebra.h: define UINT32_MAX for those systems which do not provide it. * bgp_attr.h: define BGP_MED_MAX. * bgp_route.c: update defines/constants to BGP_MED_MAX. * bgp_routemap.c: ditto. clean up route_match_metric_compile slightly to avoid unneccesary XMALLOC. --- bgpd/bgp_routemap.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) (limited to 'bgpd/bgp_routemap.c') diff --git a/bgpd/bgp_routemap.c b/bgpd/bgp_routemap.c index a2923fb1..a2635151 100644 --- a/bgpd/bgp_routemap.c +++ b/bgpd/bgp_routemap.c @@ -310,14 +310,13 @@ route_match_metric_compile (char *arg) { u_int32_t *med; char *endptr = NULL; + unsigned long tmpval; + tmpval = strtoul (arg, &endptr, 10); + if (*endptr != '\0' || tmpval == ULONG_MAX) + return NULL; med = XMALLOC (MTYPE_ROUTE_MAP_COMPILED, sizeof (u_int32_t)); - *med = strtoul (arg, &endptr, 10); - if (*endptr != '\0' || *med == ULONG_MAX) - { - XFREE (MTYPE_ROUTE_MAP_COMPILED, med); - return NULL; - } + *med = tmpval; return med; } @@ -879,8 +878,8 @@ route_set_metric (void *rule, struct prefix *prefix, if (strncmp (metric, "+", 1) == 0) { - if (bgp_info->attr->med/2 + metric_val/2 > UINT32_MAX/2) - bgp_info->attr->med = UINT32_MAX-1; + if (bgp_info->attr->med/2 + metric_val/2 > BGP_MED_MAX/2) + bgp_info->attr->med = BGP_MED_MAX - 1; else bgp_info->attr->med += metric_val; } -- cgit v1.2.1