From 47d3b6078a6c885e03d28bae3397b71a827473f5 Mon Sep 17 00:00:00 2001 From: "Jorge Boncompte [DTI2]" Date: Mon, 7 May 2012 16:53:11 +0000 Subject: micro-op bgp_node_[get|lookup]() and route_node_[get|lookup]() Reduce indirection for values that doesn't change in the loop. Signed-off-by: Jorge Boncompte [DTI2] [adjusted after dropping previous patch] Signed-off-by: David Lamparter --- bgpd/bgp_table.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'bgpd/bgp_table.c') diff --git a/bgpd/bgp_table.c b/bgpd/bgp_table.c index a249c23d..3385a934 100644 --- a/bgpd/bgp_table.c +++ b/bgpd/bgp_table.c @@ -289,16 +289,18 @@ struct bgp_node * bgp_node_lookup (const struct bgp_table *table, struct prefix *p) { struct bgp_node *node; + u_char prefixlen = p->prefixlen; + const u_char *prefix = &p->u.prefix; node = table->top; - while (node && node->p.prefixlen <= p->prefixlen && + while (node && node->p.prefixlen <= prefixlen && prefix_match (&node->p, p)) { - if (node->p.prefixlen == p->prefixlen && node->info) + if (node->p.prefixlen == prefixlen && node->info) return bgp_lock_node (node); - node = node->link[prefix_bit(&p->u.prefix, node->p.prefixlen)]; + node = node->link[prefix_bit(prefix, node->p.prefixlen)]; } return NULL; @@ -311,19 +313,21 @@ bgp_node_get (struct bgp_table *const table, struct prefix *p) struct bgp_node *new; struct bgp_node *node; struct bgp_node *match; + u_char prefixlen = p->prefixlen; + const u_char *prefix = &p->u.prefix; match = NULL; node = table->top; - while (node && node->p.prefixlen <= p->prefixlen && + while (node && node->p.prefixlen <= prefixlen && prefix_match (&node->p, p)) { - if (node->p.prefixlen == p->prefixlen) + if (node->p.prefixlen == prefixlen) { bgp_lock_node (node); return node; } match = node; - node = node->link[prefix_bit(&p->u.prefix, node->p.prefixlen)]; + node = node->link[prefix_bit(prefix, node->p.prefixlen)]; } if (node == NULL) @@ -347,7 +351,7 @@ bgp_node_get (struct bgp_table *const table, struct prefix *p) else table->top = new; - if (new->p.prefixlen != p->prefixlen) + if (new->p.prefixlen != prefixlen) { match = new; new = bgp_node_set (table, p); -- cgit v1.2.1