From 30a2231a4881f53deca61ef7a62b225a43dab4c5 Mon Sep 17 00:00:00 2001 From: Paul Jakma Date: Fri, 15 Aug 2008 14:05:22 +0100 Subject: [warnings] Fix various SOS warnings 2008-08-15 Paul Jakma * */*: Fix various problems flagged by Sun Studio compiler. - ' ' obsolescent in declarations - empty statements (';' after ALIAS definitions) - implicit declarations (e.g printstack in lib/log.c) - "\%" in printf string instead of "%%" - loops that return on the first iteration (legitimately, but compiler can't really know), e.g. bgp_routemap.c - internal declarations which mask prototypes. --- lib/daemon.c | 1 + lib/filter.c | 2 +- lib/log.c | 4 ++++ lib/plist.c | 2 +- 4 files changed, 7 insertions(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/daemon.c b/lib/daemon.c index e73a74f1..c473555b 100644 --- a/lib/daemon.c +++ b/lib/daemon.c @@ -21,6 +21,7 @@ */ #include +#include #ifndef HAVE_DAEMON diff --git a/lib/filter.c b/lib/filter.c index 069919bb..7aeb8deb 100644 --- a/lib/filter.c +++ b/lib/filter.c @@ -138,7 +138,7 @@ filter_free (struct filter *filter) } /* Return string of filter_type. */ -const static char * +static const char * filter_type_str (struct filter *filter) { switch (filter->type) diff --git a/lib/log.c b/lib/log.c index 677cf9ad..407904d5 100644 --- a/lib/log.c +++ b/lib/log.c @@ -30,6 +30,10 @@ #ifndef SUNOS_5 #include #endif +/* for printstack on solaris */ +#ifdef HAVE_UCONTEXT_H +#include +#endif static int logfile_fd = -1; /* Used in signal handler. */ diff --git a/lib/plist.c b/lib/plist.c index 6caece0e..4b498c4d 100644 --- a/lib/plist.c +++ b/lib/plist.c @@ -518,7 +518,7 @@ prefix_list_entry_add (struct prefix_list *plist, } /* Return string of prefix_list_type. */ -const static char * +static const char * prefix_list_type_str (struct prefix_list_entry *pentry) { switch (pentry->type) -- cgit v1.2.1