From 91f3e525a95d6a86f916872116af162eb3bdae5d Mon Sep 17 00:00:00 2001 From: gdt Date: Thu, 9 Dec 2004 14:51:03 +0000 Subject: ospf_apiserver_term: Remove unused variable. Add comment: this is seriously broken, and needs fixing. It appears likely to segfault if ever called. Comments please - should I make the fix I suggest in the comment? -gdt --- ospfd/ospf_apiserver.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'ospfd/ospf_apiserver.c') diff --git a/ospfd/ospf_apiserver.c b/ospfd/ospf_apiserver.c index 4f294f71..07b8f211 100644 --- a/ospfd/ospf_apiserver.c +++ b/ospfd/ospf_apiserver.c @@ -180,7 +180,7 @@ out: void ospf_apiserver_term (void) { - struct listnode *node, *nnode; + struct listnode *node; struct ospf_apiserver *apiserv; /* Unregister wildcard [0/0] type */ @@ -189,6 +189,11 @@ ospf_apiserver_term (void) /* Free all client instances */ while ( (node = listhead (apiserver_list)) != NULL) + /* + * XXX: this is just plain odd/wrong. Is there a missing + * apiserv = (struct ospf_apiserver *) node; + * ? + */ ospf_apiserver_free (apiserv); /* Free client list itself */ -- cgit v1.2.1