From 84f6c0d6cecd039b5dc529b6c5eba136840a4010 Mon Sep 17 00:00:00 2001 From: Denis Ovsienko Date: Sun, 28 Aug 2011 22:38:45 +0400 Subject: ospfd: address more trivial compiler warnings * ospf_ase.c * ospf_ase_complete_direct_routes(): dismiss unused variable * ospf_ase_calculate_route(): put assignments into parentheses --- ospfd/ospf_ase.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'ospfd') diff --git a/ospfd/ospf_ase.c b/ospfd/ospf_ase.c index 5d0cae42..7b7a798a 100644 --- a/ospfd/ospf_ase.c +++ b/ospfd/ospf_ase.c @@ -135,7 +135,6 @@ ospf_ase_complete_direct_routes (struct ospf_route *ro, struct in_addr nexthop) { struct listnode *node; struct ospf_path *op; - struct interface *ifp; for (ALL_LIST_ELEMENTS_RO (ro->paths, node, op)) if (op->nexthop.s_addr == 0) @@ -451,8 +450,8 @@ ospf_ase_calculate_route (struct ospf *ospf, struct ospf_lsa * lsa) /* if there is a Intra/Inter area route to the N do not install external route */ - if (rn = route_node_lookup (ospf->new_table, - (struct prefix *) &p)) + if (NULL != (rn = route_node_lookup (ospf->new_table, + (struct prefix *) &p))) { route_unlock_node(rn); if (rn->info == NULL) @@ -463,8 +462,8 @@ ospf_ase_calculate_route (struct ospf *ospf, struct ospf_lsa * lsa) } /* Find a route to the same dest */ /* If there is no route, create new one. */ - if (rn = route_node_lookup (ospf->new_external_route, - (struct prefix *) &p)) + if (NULL != (rn = route_node_lookup (ospf->new_external_route, + (struct prefix *) &p))) route_unlock_node(rn); if (!rn || (or = rn->info) == NULL) -- cgit v1.2.1