From 6a250b099fe25627e32e5ca58f5677ba5227f816 Mon Sep 17 00:00:00 2001 From: gdt Date: Thu, 9 Dec 2004 14:48:12 +0000 Subject: Add const to char * to quiet warnings. Note two warnings in comments. The serious one is that struct interface->ifindex probably needs to be signed, ssince we store and compare to -1. --- zebra/ChangeLog | 4 ++++ zebra/kernel_socket.c | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) (limited to 'zebra') diff --git a/zebra/ChangeLog b/zebra/ChangeLog index 696676bc..8d09f502 100644 --- a/zebra/ChangeLog +++ b/zebra/ChangeLog @@ -1,3 +1,7 @@ +2004-12-09 Greg Troxel + + * kernel_socket.c (rtmsg_debug): char * => const char * + 2004-12-07 Andrew J. Schorr * *.c: Change level of debug messages to LOG_DEBUG. diff --git a/zebra/kernel_socket.c b/zebra/kernel_socket.c index e0f2a8f2..9027cd6a 100644 --- a/zebra/kernel_socket.c +++ b/zebra/kernel_socket.c @@ -276,6 +276,7 @@ ifm_read (struct if_msghdr *ifm) sdl = (struct sockaddr_dl *)cp; break; } + /* XXX warning: pointer of type `void *' used in arithmetic */ cp += SAROUNDUP(cp); } } @@ -324,6 +325,10 @@ ifm_read (struct if_msghdr *ifm) * If ifp does not exist or has an invalid index (-1), create or * fill in an interface. */ + /* + * XXX warning: comparison between signed and unsigned + * ifindex should probably be signed + */ if ((ifp == NULL) || (ifp->ifindex == -1)) { /* @@ -812,7 +817,7 @@ rtm_write (int message, static void rtmsg_debug (struct rt_msghdr *rtm) { - char *type = "Unknown"; + const char *type = "Unknown"; struct message *mes; for (mes = rtm_type_str; mes->str; mes++) -- cgit v1.2.1