quagga/isisd, branch isis-redist

isisd: Add cleanup code

2014-01-12T20:53:47+00:00

isisd: first feeble attempt at redistribute

2014-01-08T12:53:50+00:00

lib/command.c: rewrite command matching/parsing

2014-01-07T23:49:41+00:00

Add support for keyword commands.

Signed-off-by: Christian Franke

isisd: add a slight delay to lsp_regenerate_schedule

2014-01-07T23:49:28+00:00

isisd implements a holdoff interval and will refrain from regenerating
an lsp if the difference between the current time and its last refresh
is less than the holdoff interval, but instead, it will schedule a timer
to regenerate the lsp after the holdoff interval has passed.

This implementation has one disadvantage in the case where there is a
succession of calls to lsp_regenerate_schedule. In such a case, the
first call will trigger an immediate regeneration of the lsp, while the
other calls will only schedule the regeneration timer. This leads to
cases where it takes holdoff interval time for information to propagate,
just because the information was only available e.g. at the second call
of lsp_regenerate_schedule in such a succession of calls.

By not immediately regenerating an lsp if the last generation time
is sufficiently long ago, but instead scheduling the regeneration with a
very small delay, we allow all information from such a succession of
calls to be considered.

Signed-off-by: Christian Franke

isisd: do remove ipv6 routes from Zebra

2014-01-07T01:00:37+00:00

We can abort isis_zebra_route_del_ipv6 if the route in question has
ISIS_ROUTE_FLAG_ZEBRA_SYNCED unset, meaning it's not in the kernel.
Aborting the function if the flag is set prevents us from removing
any routes.

Signed-off-by: Christian Franke

isisd, ospf6d: use bug-report information from autoconf

2013-07-31T15:58:05+00:00

Signed-off-by: Christian Franke 
Signed-off-by: David Lamparter

isisd: fix ipv6 metric endianness

2012-12-12T14:38:14+00:00

the isis ipv6 reachability metric is transmitted in big endian / network
format, but isis_spf_process_lsp() does not convert this into host endian
format when mucking around with local cost + received metric.  This patch
fixes this problem and makes received ipv6 metrics work properly on
little-endian machines.

Signed-off-by: David Lamparter

isisd: verify metrics on metric-style transition

2012-12-12T14:38:08+00:00

When switching to metric-style transition, circuit metrics should also be
verified to be in the narrow range 0..63.

Signed-off-by: Christian Franke 
Signed-off-by: David Lamparter

isisd: fix metrics check for metric-style narrow

2012-12-12T14:38:08+00:00

When switching to narrow metric style, all configured circuits are
verified to have a valid narrow style metric. Check te_metric instead
of metric_default as the latter is only 8bit wide and may overflow for
wide style metrics.

Signed-off-by: Christian Franke 
Signed-off-by: David Lamparter

isisd: address Coverity warnings

2012-12-12T14:38:08+00:00

this fixes a bunch of issues found by Coverity SCAN and flagged as
"high" impact -- although, they're all rather minute issues.

* isisd/isis_adjacency.c: one superfluous check, one possible NULL deref
* isisd/isis_circuit.c: two prefix memory leaks
* isisd/isis_csm.c: one missing break
* isisd/isis_lsp.c: one possible NULL deref
* isisd/isis_pfpacket.c: one error-case fd leak
* isisd/isis_route.c: one isis_route_info memory leak
* isisd/isis_routemap.c: one... fnord
* isisd/isis_tlv.c: one infinite loop

Reported-by: Coverity SCAN
Signed-off-by: David Lamparter