diff options
| author | Paul Jakma <paul.jakma@sun.com> | 2008-05-29 18:29:16 +0000 |
|---|---|---|
| committer | Paul Jakma <paul.jakma@sun.com> | 2008-05-29 18:29:16 +0000 |
| commit | 0d6b2ee249e9efba30da3236c413bf03c7b27ed9 (patch) | |
| tree | 4d9320f2c34f0c127b58b92f59e2c2afd2d5818f /bgpd | |
| parent | 768a27ea7ba25257c79689af83ab37945dc1cc3c (diff) | |
[daemons] Sanity check port number arguments before use
2008-05-29 Martin Nagy <mnagy@redhat.com>
* */*main.c: Sanity check port numbers before using.
Diffstat (limited to 'bgpd')
| -rw-r--r-- | bgpd/bgp_main.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/bgpd/bgp_main.c b/bgpd/bgp_main.c index e6d34afc..2089c6b5 100644 --- a/bgpd/bgp_main.c +++ b/bgpd/bgp_main.c @@ -203,6 +203,7 @@ main (int argc, char **argv) int dryrun = 0; char *progname; struct thread thread; + int tmp_port; /* Set umask before anything for security */ umask (0027); @@ -238,7 +239,11 @@ main (int argc, char **argv) pid_file = optarg; break; case 'p': - bm->port = atoi (optarg); + tmp_port = atoi (optarg); + if (tmp_port <= 0 || tmp_port > 0xffff) + bm->port = BGP_PORT_DEFAULT; + else + bm->port = tmp_port; break; case 'A': vty_addr = optarg; @@ -252,7 +257,8 @@ main (int argc, char **argv) break; } vty_port = atoi (optarg); - vty_port = (vty_port ? vty_port : BGP_VTY_PORT); + if (vty_port <= 0 || vty_port > 0xffff) + vty_port = BGP_VTY_PORT; break; case 'r': retain_mode = 1; |