diff options
| author | Paul Jakma <paul.jakma@sun.com> | 2007-05-10 02:38:51 +0000 |
|---|---|---|
| committer | Paul Jakma <paul.jakma@sun.com> | 2007-05-10 02:38:51 +0000 |
| commit | 6f0e3f6e17687eb25b7b77c4fdc8324837d4700f (patch) | |
| tree | 8a94d9212060f0f2ee7cbd0079c2687eed7348dc /bgpd | |
| parent | 08d3d5b398ae81de7659509f159e814d1bbd4375 (diff) | |
[autoconf] bugs 162,303,178: Fix 'present but can not be compiled' warnings
2007-05-09 Paul Jakma <paul.jakma@sun.com>
* configure.ac: sys/conf.h depends on sys/param.h, at least on
FBSD 6.2.
(bug #363) Should check for in_pktinfo for IRDP
2006-05-27 Paul Jakma <paul.jakma@sun.com>
* configure.ac: General cleanup of header and type checks, introducing
an internal define, QUAGGA_INCLUDES, to build up a list of
stuff to include so as to avoid 'present but cant be compiled'
warnings.
Misc additional checks of things missing according to autoscan.
Add LIBM, for bgpd's use of libm, so as to avoid burdening
LIBS, and all the binaries, with libm linkage.
Remove the bad practice of using m4 changequote(), just
quote the []'s in the case statements properly.
This should fix bugs 162, 303 and 178.
* */*.{c,h}: Update all HAVE_* to the standard autoconf namespaced
HAVE_* defines. I.e. HAVE_SA_LEN -> HAVE_STRUCT_SOCKADDR_SA_LEN,
* bgpd/Makefile.am: Add LIBM to bgpd's LDADD, for pow().
Diffstat (limited to 'bgpd')
| -rw-r--r-- | bgpd/Makefile.am | 2 | ||||
| -rw-r--r-- | bgpd/bgp_network.c | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/bgpd/Makefile.am b/bgpd/Makefile.am index 0fe82ae0..80e93284 100644 --- a/bgpd/Makefile.am +++ b/bgpd/Makefile.am @@ -22,7 +22,7 @@ noinst_HEADERS = \ bgp_advertise.h bgp_snmp.h bgp_vty.h bgpd_SOURCES = bgp_main.c -bgpd_LDADD = libbgp.a ../lib/libzebra.la @LIBCAP@ +bgpd_LDADD = libbgp.a ../lib/libzebra.la @LIBCAP@ @LIBM@ examplesdir = $(exampledir) dist_examples_DATA = bgpd.conf.sample bgpd.conf.sample2 diff --git a/bgpd/bgp_network.c b/bgpd/bgp_network.c index 61661c0d..8040e47d 100644 --- a/bgpd/bgp_network.c +++ b/bgpd/bgp_network.c @@ -159,9 +159,9 @@ bgp_bind_address (int sock, struct in_addr *addr) memset (&local, 0, sizeof (struct sockaddr_in)); local.sin_family = AF_INET; -#ifdef HAVE_SIN_LEN +#ifdef HAVE_STRUCT_SOCKADDR_IN_SIN_LEN local.sin_len = sizeof(struct sockaddr_in); -#endif /* HAVE_SIN_LEN */ +#endif /* HAVE_STRUCT_SOCKADDR_IN_SIN_LEN */ memcpy (&local.sin_addr, addr, sizeof (struct in_addr)); if ( bgpd_privs.change (ZPRIVS_RAISE) ) @@ -379,9 +379,9 @@ bgp_socket (struct bgp *bgp, unsigned short port) sin.sin_family = AF_INET; sin.sin_port = htons (port); socklen = sizeof (struct sockaddr_in); -#ifdef HAVE_SIN_LEN +#ifdef HAVE_STRUCT_SOCKADDR_IN_SIN_LEN sin.sin_len = socklen; -#endif /* HAVE_SIN_LEN */ +#endif /* HAVE_STRUCT_SOCKADDR_IN_SIN_LEN */ if ( bgpd_privs.change (ZPRIVS_RAISE) ) zlog_err ("bgp_socket: could not raise privs"); |