summaryrefslogtreecommitdiff
path: root/ports
diff options
context:
space:
mode:
authorPaul Jakma <paul@quagga.net>2010-11-23 21:28:03 +0000
committerPaul Jakma <paul@quagga.net>2011-03-21 13:51:14 +0000
commitf6f434b2822c453f898552537180a812538bd19e (patch)
tree81f5de3c1eeb6679635e7363396c08b807b04ad9 /ports
parent50ef565e4e689ba653b9709be4d28a01f6cca885 (diff)
bgpd: Try fix extcommunity resource allocation probs, particularly with 'set extcom..'
* Extended communities has some kind of resource allocation problem which causes a double-free if the 'set extcommunity ...' command is used. Try fix by properly interning extcommunities. Also, more generally, make unintern functions take a double pointer so they can NULL out callers references - a usefully defensive programming pattern for functions which make refs invalid. Sadly, this patch doesn't fix the problem entirely - crashes still occur on session clear. * bgp_ecommunity.h: (ecommunity_{free,unintern}) take double pointer args. * bgp_community.h: (community_unintern) ditto * bgp_attr.h: (bgp_attr_intern) ditto * bgp_aspath.h: (bgp_aspath.h) ditto * (general) update all callers of above * bgp_routemap.c: (route_set_ecommunity_{rt,soo}) intern the new extcom added to the attr, and unintern any old one. (route_set_ecommunity_{rt,soo}_compile) intern the extcom to be used for the route-map set. (route_set_ecommunity_*_free) unintern to match, instead of free (route_set_ecommunity_soo) Do as _rt does and don't just leak any pre-existing community, add to it (is additive right though?)
Diffstat (limited to 'ports')
0 files changed, 0 insertions, 0 deletions