diff options
| author | paul <paul> | 2006-01-17 17:26:25 +0000 |
|---|---|---|
| committer | paul <paul> | 2006-01-17 17:26:25 +0000 |
| commit | 98fd1e61212ea98154e7cc4b6deed41a07794523 (patch) | |
| tree | 961f28ead9a2eb24fb7660cd52023489a7b431e2 /ripd/ChangeLog | |
| parent | 6726f950ad25daa532e75dc7a6875b340ae0447d (diff) | |
[ripd] Fix verification of received MD5 authenticated packets
2006-01-17 Paul Jakma <paul.jakma@sun.com>
* ripd.c: (rip_auth_md5) remove pdigest, not needed.
Use a local buffer for the auth_str, where it can be properly
nul padded. Do so, hence fixing MD5 authentication.
Key looked up via key ring should be used in preference to
the RIPv1 simple password, not other way around.
No need to copy around digests, we can reference them
directly.
The auth_len received can't be trusted, some implementations
lie (e.g. older ripd).
(rip_auth_md5_ah_write) rename len local variable to doff
to be consistent with other functions.
(rip_auth_header_write) add the missing return.
(rip_auth_md5_set) use the proper constructs to access stream.
Diffstat (limited to 'ripd/ChangeLog')
| -rw-r--r-- | ripd/ChangeLog | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/ripd/ChangeLog b/ripd/ChangeLog index a3c0e24b..2b79a61d 100644 --- a/ripd/ChangeLog +++ b/ripd/ChangeLog @@ -1,3 +1,19 @@ +2006-01-17 Paul Jakma <paul.jakma@sun.com> + + * ripd.c: (rip_auth_md5) remove pdigest, not needed. + Use a local buffer for the auth_str, where it can be properly + nul padded. Do so, hence fixing MD5 authentication. + Key looked up via key ring should be used in preference to + the RIPv1 simple password, not other way around. + No need to copy around digests, we can reference them + directly. + The auth_len received can't be trusted, some implementations + lie (e.g. older ripd). + (rip_auth_md5_ah_write) rename len local variable to doff + to be consistent with other functions. + (rip_auth_header_write) add the missing return. + (rip_auth_md5_set) use the proper constructs to access stream. + 2005-10-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu> * ripd.c: (rip_response_process) Instead of calling |