summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2003-04-19From: Israel Keys <ikeys@agile.tv>paul
Subject: [zebra 18677] zebra initialisation bug and patch Hi All, I have found a bug in zebra that prevents its routing table and interface database from being initialised properly. The problem occurs when a request is made via the netlink socket but the kernel produces a EWOULDBLOCK/EAGAIN when the result is trying to be retrieved via a recvmsg(). Zebra does not do anything about this and continues to function (with an empty routing table and interface list) as if nothing has happened. With no such information the routing protocol dosn't work! Two functions are called during the initialisation of Zebra: interface_lookup_netlink() and netlink_route_read() - obtaining the interfaces and routing table from the kernel respectively. These are the only time these functions are called. These functions, interface_lookup_netlink() and netlink_route_read(), use netlink_parse_info() to recieve the data from the netlink socket. The problem is, netlink_parse_info() returns (without error) when its call to recvmsg() results in an errno EWOULDBLOCK/EAGAIN. This behaviour is expected by other funtions calling netlink_parse_info() - netlink_parse_info is simply recalled at a later stage. However, on initialisation it is never recalled. Since zebra is expected to nothing else during initialisation it was easiest to temporarily change the netlink socket to BLOCK and wait indefinently until the kernel responds with the required information. Attached is a patch with these changes. Comments and questions are welcome. Please inform me if this patch is added to the Zebra source. --israel
2003-04-18From: Sergey Vyshnevetskiy <serg@vostok.net>paul
Subject: [zebra 18689] [PATCH] misc patch Add missing param to zlog
2003-04-18From: Sergey Vyshnevetskiy <serg@vostok.net>paul
Subject: [zebra 18689] [PATCH] misc patch remove unused vars
2003-04-18Fix up vtysh.c compile warningspaul
(following from initial patches by Amir & Sergey Vyshnevetskiy ([zebra 18689])
2003-04-17Denis Ovsienko <zebra@pilot.org.ua>paul
Subject: [zebra 18767] possible SIGSEGV Fix incorrect memset
2003-04-13From: Hasso Tepper <hasso@estpak.ee>paul
To: zebra@zebra.org Subject: [zebra 18648] [PATCH] Selforiginated Type-7 LSA's are not flushed from lsdb
2003-04-13Author: amirpaul
Date: 2003-04-10 14:32:31 +0200 (Thu, 10 Apr 2003) New Revision: 212 Modified: zebra-ag/trunk/ospfd/ospf_lsa.c Log: I've fixed a small opaque lsa bug which got triggered when deleting opaque lsa of type 11. It used area->ospf->.. when area was null. This was replaced by a ospf = ospf_lookyp(); ospf->...
2003-04-09Author: ralphpaul
Date: 2003-04-08 10:37:12 +0200 (Tue, 08 Apr 2003) Log: new ospfclient application with usage and more comments.
2003-04-09Amir - rev 198paul
Log: Removed unused variable in interface.c
2003-04-09Amir - revision 197paul
Log: I've fixed a small bug in connected_down_ipv4(): I changed if (ifc_pointopoint (ifc)) into if (ifc_pointopoint (ifc) && dest) like show in connected_up_ipv4() After changing this 'ip address x/y'; 'no ip address x/y' works without crash when done in sequence.
2003-04-09Add Makefile.in to the remaining .cvsignore'spaul
Add ospfclient to ospfclient/.cvsignore
2003-04-09Updated to reflect removal of auto-built filespaul
2003-04-09Remove vtysh_cmd.c from the repository.paul
Add dependency on rebuild target for vtysh_cmd.c to Makefile.am
2003-04-08Undo commenting of a debug conditional. make it conditional again.paul
2003-04-07Hasso Tepper <hasso@estpak.ee>:paul
add NSSA debug statement
2003-04-07Change vty socket path defines to the global definespaul
2003-04-07Removed stray hard coded vty socket pathspaul
2003-04-07define localstatedir for configurepaul
2003-04-07Indentation fixpaul
2003-04-07Copy configure.ac to configure.in.paul
2003-04-07[zebra 18626] move zebra socket paths to configure.acpaul
moved definition of the various socket paths from the per daemon header files into configure.ac. it will set the paths to be in the directory specified by --localstatedir=<prefix> or otherwise will try to guess as best it can ( a la pid file path detection - which probably should try reference ${prefix} too). the present hardcoded socket path, /tmp, isnt really correct. should be in /var somewhere really.
2003-04-07Remove auto* files from the repository.paul
Developers working with the repository should have the appropriate tools. Out-of-sync files cause far too many problems with users as well as auto* scripts not being half as portable across systems as they ought to be. make-dist exists for a reason. Todo: make the CVS snapshot script do make-dist, and use the resulting tarball as the snapshot.
2003-04-07Compile fix - convert foreach_lsa to LSDB_LOOPpaul
2003-04-06Latest ospfapi sync from Amir to fixup wrt to zebra.org changes.paul
2003-04-05Fixes from Amir to merge apiserver with zebra.org changespaul
2003-04-05Add tests for debug enabled to PtMP LSA creation functionspaul
2003-04-042003-04-04 Paul Jakma <paul@dishone.st>paul
* Sync to Zebra CVS * Fix lib/thread.h leak * Fix small Opaque LSA leak * Do not configure OSPF interfaces for secondary addresses * vtysh fixes from Hasso * Dave Watson's missing ntohs fix
2003-04-03From: David Watson <dwatson@eecs.umich.edu>paul
Subject: [zebra 18573] PATCH ospfd: byte order error in assert statement I found a bug in the ospfd code tickled this morning by a Type 1 LSA with exactly 62 entries (LSA length of 768, or 0x0300). A missing ntohs in ospf_lsa.c:ospf_lsa_different() causes an assert statement to fail, stopping ospfd. > assert (l1->data->length > OSPF_LSA_HEADER_SIZE); So, a length of type 768 turns into a length of 3 which is obviously less than 20. David
2003-03-31Fix make distpaul
2003-03-28Add 'no description' commandpaul
2003-03-28See http://bugzilla.dishone.st/show_bug.cgi?id=13paul
Fix from hasso tepper <hasso@linux.ee>
2003-03-28Do not configure ospf for secondary prefixes.paul
Preliminary fix to at least allow heartbeat to work with ospfd when Heartbeat failover address has same prefixlength as main address.
2003-03-28Amir Guindehi <amir@datacore.ch>:paul
I got it to compile. The problem was that major functions newly need a struct ospf *ospf as the first argument. I tried to take the nearest struct ospf *ospf around the function needing it, because i was not sure if all those pointers to struct ospf * all point to the same (global) struct ospf * which you also get when you call ospf_get(). I used area->ospf where I had the area, I used oi->ospf, where I had an interface, I used lsa->oi->ospf where I had an lsa and i used ospf_get() where I had nothing. I hope that's correct and works. We will see. It compiles now without errors. Daemon is tested and works. The opaque lsa part is not yet tested. I will do that as soon as srrd is ready.
2003-03-28Fix OSPFAPI buildpaul
2003-03-28Fix leak of an opaque-lsa scratch link-listpaul
2003-03-28Remove redundant memsetpaul
2003-03-27Need to free the defunct funcname if we grab a thread from the unused list.paul
2003-03-252003-03-25 Paul Jakma <paul@dishone.st>paul
* sync to latest zebra CVS * spec file: updated and added define for ospf-api/client NB: OSPF-API has been broken by the zebra.org changes, which has added struct ospf * as a new arg to many functions
2003-03-21Amir Guindehi <amir@datacore.ch>:paul
Fix up build for OSPF-API (dependent on opaque-lsa) Add disable-ospfapi. Fix up net-snmp detection.
2003-03-21Fix assert in ospf_api where interface is not configured in ospf.paul
2003-03-19Copied configure.in to configure.ac rather than other way around.paul
Restore Amir's netsnmp build fix.
2003-03-18Update configure.ac to match configure.in.paul
still perplexed why removing configure.in breaks certain autoconf sites.
2003-03-18Add new zebra-devel packagepaul
2003-03-18Fix build for net-snmppaul
2003-03-17Amir Guindehi <amir@datacore.ch>paul
-------------------------------- I've attached a small patch for zebra-pj, which adds the installation of libospf.a libzebra.a, libospfapi.a and the needed headers for ospfapi clients. the headers get installed to /usr/include/ospfd/* and /usr/include/ospfapi.
2003-03-17Put configure.ac back.paul
2003-03-17Update auto files.paul
No doubt builds will now break for everyone. (works here - autoconf 2.13)
2003-03-17Addition of OSPF-API - Amir Guindehi <amir@datacore.ch>paul
2003-03-17Addition of OSPF-API - Amir Guindehi <nospam.amir@datacore.ch>paul
2003-03-17configure.ac is redundant.paul
use configure.in