| Age | Commit message (Collapse) | Author |
|---|
|
* ospf_packet.c: (ospf_ls_upd_send_queue_event) undo fix suggested
Mikael Lonnroth. As per Kamatchi Soundaram /
[zebra 19590], original behaviour is correct.
|
|
* ospf_vty.c: (global) add, unused, description array for lsa flags.
(show_ip_ospf_database_header): pretty print options, printf hex
numbers as 0x, print lsa flags and note if it is a translated LSA.
(show_lsa_detail_proc): print out OSPF_LSA_LOCAL_XLT LSAs.
* ospf_packet.c: (ospf_write) print out destination IP in debug info
if write fails.
|
|
* ospf_packet.c: (ospf_ls_upd_send_queue_event) clean up list node
and unlock lsa if we break early. (eg packet size too large).
|
|
|
|
* ospf_vty.c (ospf_area_stub_no_summary): fix typo.
(ospf_area_nssa_cmd_handler): new function to handle the
area.*nssa commands.
(ospf_area_nssa_cmd): changed to call ospf_area_nssa_cmd_handler
(ospf_area_nssa_translate_cmd) ditto
(ospf_area_nssa_translate_cmd): changed from ALIAS to defun, call
ospf_area_nssa_cmd_handler
(ospf_area_nssa_translate_no_summary_cmd): ditto
(no_ospf_area_nssa_cmd): call ospf_schedule_abr_task()
(show_ip_ospf_area): Formatting cleanups. Properly print out NSSA
area configuration.
show_router_lsa_detail: Add missing newline
(show_network_lsa_detail): ditto
(show_summary_lsa_detail): ditto
(show_summary_asbr_lsa_detail): ditto
(show_ip_ospf_route_router): fix spacing
(config_write_ospf_area): actually write out proper state for NSSA
area.
|
|
* ospf_abr.c (ospf_abr_nssa_am_elected): new function.
Look through LSDB for an area and try determine whether other
routers are more 'electable' than this router. Presumes caller
has checked Role.
(ospf_abr_nssa_check_status): new function. check any NSSA related
status changes. At present determines NSSATranslatorState should
be enabled or disabled.
(ospf_abr_announce_network_to_area): remove the redundant
call to ospf_abr_announce_network_to_area() (as per Vadim,
[zebra 14710], problem 7).
(global): Update NSSATranslator to NSSATranslatorState as per
ospfd.h changes
(ospf_abr_announce_nssa_defaults): call
ospf_abr_announce_network_to_area() to inject default summaries.
(ospf_abr_nssa_task): undo commented out calls to
ospf_abr_prepare_aggregates() and ospf_abr_send_nssa_aggregates(),
if they're borked, lets fix them.
(ospf_abr_task): remove call to ospf_abr_nssa_task() - move this
to the timer scheduler.
(ospf_abr_task_timer): call ospf_abr_nssa_task() and
ospf_abr_nssa_check_status()
(misc): some minor reformatting.
|
|
* ospfd.c (ospf_area_nssa_set): Set defaults for NSSA Role, State
and Stability Interval and no_summary.
(ospf_area_nssa_translator_role_(un?)set): Update to
NSSATranslatorRole
|
|
* ospfd.h (struct ospf_area): remove NSSATranslator. Add
NSSATranslatorState and NSSATranslatorStabilityInterval (currently
not used).
(global): add OSPF_NSSA_TRANS_STABLE_DEFAULT, default for
NSSATranslatorStabilityInterval. Update the LSA_NSSA_GET to
reflect struct ospf_area changes.
|
|
* ospf_route.c: delete routes generated from AS-External routes if
there is a inter/intra route. Adds ospf_route_delete_same_ext()
which prunes external routes, which is called from
ospf_route_install() when new route table is installed.
|
|
* ospf_lsa.h: elaborate on comment for ROUTER_LSA_NT
add IS_ROUTER_LSA_NT macro.
|
|
* ospf_lsa.c (router_lsa_flags): Set the correct flags for
router-lsa's. Eg OSPF_FLAG_ASBR is /not/ an LSA flag, its an
internal ospfd flag (just happens to have same value as
ROUTER_LSA_EXTERNAL). Set ROUTER_LSA_EXTERNAL for ASBRs,
ROUTER_LSA_BORDER for ABRs and ROUTER_LSA_NT for NSSA ABRs which
are OSPF_NSSA_ROLE_ALWAYS translators.
|
|
* ospf_interface.c (ospf_vl_set_params): new router LSA is not
generated when the cost of the routing entry for the virtual
link endpoint has changed. If the cost to reach the virtual link's
endpoint has changed, add router LSA timer for the backbone area.
|
|
* ospf_dump.h: fix NSSA debug define
|
|
* *.texi: update the docs a bit. Add some info about
zebra.dishone.st in the overview. Add link-detect and update
static routes section in zebra. Add write-config in vtysh. Update
version handling and add passive-interface default for ripd.
|
|
* rip_interface.c: add 'default' to passive-interface command DEFUN
|
|
* ospf6d/ospf6_message.c: Change memcpy() to strcpy() to prevent
copying of extraneous junk - suggested by Anil Madhavapeddy
<anil@recoil.org> on bug-zebra@gnu.org.
|
|
* ospfd/ospf_zebra.c: Run it through indent -nut to fix the $%^@ing
annoying mix of tabs and spaces.
|
|
* ospfd/ospf_zebra.c: [zebra 19434] fix for disappearing OSPF routes
modify ospf_zebra_delete() to specify nexthop when deleting routes
with zebra.
|
|
* zebra/rt_netlink.c: Debug statements added to
netlink_route_multipath()
* zebra/zebra_rib.c: If route has a gateway, delete only existing
route with that specified gateway.
|
|
* Fix lib/smux.c's reliance on daemons exporting struct
thread_master *master.
|
|
* ospfd/ospf_packet.c: Fix typos, extra squiggly bracket. Note to
self: in future make sure that when you test compile a change you
actually have the relevant configure options enabled.
|
|
* ospfd/ospf_packet.c: Update Hasso's hack slightly, add comment
elaborating on Hasso's, use the SET/CHECK_FLAG macros.
|
|
* lib/vty.{c,h}: Remove vty layer depending on a 'master' global,
pass the thread master in explicitly to vty_init. Sort out some
header dependency problems with lib/command.h
* zebra/: Move globals to struct zebrad. Update vty_init().
* (.*)/\1_main.c: update call to vty_init().
|
|
* zebra/ioctl.c: Properly zero-out struct ifreq before passing it
to the SIOCSIFFLAGS ioctl(2), so that it doesn't
occasionally trigger promisc mode on interface.
Reported/tested by: Vladimir B. Grebenschikov <vova@sw.ru>
(patch snarfed taken from FreeBSD ports)
|
|
* bgpd/ChangeLog: Update (wasnt commited with the fix)
|
|
* lib/privs.h (zprivs_init): do not use zlog() as it depends on
vty having been initialised (zlog calls vty_log). print to stderr
directly instead.
|
|
* bgp_clist.c (community_list_delete): honour deny statements
|
|
Compile and warning fixes for the ripd 'passive-interface default' patch.
|
|
* (bgp_clist.c): Run it through indent -nut (all indentation to
be spaced, get rid of mix of tabs and spaces)
|
|
Subject: [zebra 12403] patch for ripd to accept any version of RIP
by default
The default Cisco IOS behavior is to send RIP version 1 packets and receive
version 1 and version 2 packets. But zebra version 0.92a sends and receives
only version 2 packets by default.
I have patched the code to change zebra's default behavior to sending
version 2 packets (same as before) but receiving both versions. While
this is still not identical to Cisco's behavior, it does now accept
packets of both versions and retains backwards compatibility with
zebra configurations.
|
|
Subject: [zebra 12406] patch for ripd to support "passive-interface
default" behavior
In Cisco IOS, the router rip passive-interface subcommand can accept
an interface name of "default". In that cases, all interfaces are set
to be passive by default, and you must explicitly make it non-passive
by using the "no passive-interface <ifname>" command if you want updates
to go to that interface.
<command implemented for zebra>
|
|
* (zebra/rtadvc.): can not set checksum for ICMPV6, see:
From: Jun-ichiro itojun Hagino <itojun@iijlab.net>
Subject: [zebra 11052] setsockopt(IPV6_CHECKSUM) does not work for ICMPv6
socket
setsockopt(IPV6_CHECKSUM) does not work for ICMPv6 socket.
RFC2292 may not be clear enough about it (it talks about raw socket
and ICMPv6 socket mixed up), but the next revision
(draft-ietf-ipngwg-rfc2292bis-02.txt) is very clear about it.
> An attempt to set IPV6_CHECKSUM for an ICMPv6 socket will fail.
|
|
* (ospf_spf.c): Fix indentation - primarily the mix of tabs and spaces.
Ran through indent -nut (GNU style, but only spaces for indentation)
|
|
* Revert Cougar's sort interface names patch, causes problems with
enabling of interfaces for OSPF in ospfd.
|
|
* (ospf_spf.c): Fix consideration of costs for PtP nexthops in
ospf_nexthop_calculation().
|
|
* Fix up defaults for --enable-{user,group}
|
|
* Fix up case of --enable-vty-group not being specified
|
|
|
|
|
|
in zebra.h to make it compile in debian.
|
|
* Merge of zebra privileges
|
|
* (configure.in): removed
* (configure.ac): Fixes/cleanups backported from zprivs branch
AC_DEFINE templates added,
Indentation of nested macros,
IPv6 checks changed from independent if..fi blocks to
if...elif...fi.,
Merge piddir and ac_sockdir into one ac_statedir,
Remove world writeable dirs as candidates for ac_statedir,
ERROR out if no state dir is found or --localstatedir not
specified,
|
|
* (Makefile.am): doc should be a SUBDIR. Specify DIST_SUBDIRS to
remove dependence of make dist on configure options. Add doc/mpls
to EXTRA_DIST. redhat/ does not need a dist-hook, its already in
SUBDIR. Remove CVS/ dir from the dist doc/.
|
|
lib/debug.{c,h}: glibc backtrace printing function (from the glibc info page)
configure.ac: check for glibc backtrace and set define
lib/zebra.h: glibc backtrace support
|
|
|
|
|
|
Subject: [zebra 19263] Another memory leak!! is zebra OSPF
This memory leak gets into picture whenever any interface goes down.
Problem found and desctription: Whenever the interface goes down, the
"def_params" (member of ospf_if_info) structure memory is not freed.
Fix made: added the following line to free the "def_params" memory of
ospf_if_info before calling the "XFREE(MTYPE_OSPF_IF_INFO, ifp->info);"
The added line is:
ospf_del_if_params ((struct ospf_if_params *) IF_DEF_PARAMS (ifp));
|
|
Subject: [zebra 19262] Re: Memory leak in OSPF
Fix applied for Kamatchi's original report was to remove the auth_crypt
initialisation from the wrong function. This should fix that.
|
|
Subject: [zebra 19259] Memory leak in OSPF
The detail of the memory leak follows:
File name: ospf_interface.c
Function name: ospf_if_new_hook().
Type of leak: Overwriting the already allocated memory.
Problem found and description:
The ospf_new_if_params() fn allocates a memory for "auth_crypt" which
is overwritten, down in the fn (ospf_if_new_hook) by explicitely allocating
a memory for the same "auth_crypt".
Fix: remove allocation from ospf_new_if_params()
|
|
|
