| Age | Commit message (Collapse) | Author |
|---|
|
in lib/zebra.h, ensure that RFC3542-required CMSG_SPACE and CMSG_LEN
are defined. Warn if alignment assumptions are made, since they are
i386-centric.
in lib/sockopt.h, declare that sockopt sizes are without
CMSG_SPACE-required padding - just simple sizeof.
in ospfd/ospf_packet.c, simply use CMSG_SPACE
This should remove all instances of CMSG_ALIGN from the source code.
This is a nonstandard, though rational, construct; quagga should use
only those defines in RFC3542.
|
|
|
|
Adjust required texinfo version to 4.7 from 4.7-4.
Clarify quagga.info build process.
|
|
* memory.c: (zerror) Use zlog_err instead of fprintf to stderr.
Instead of exiting, log currenty memory usage and then abort.
(log_memstats) New function to log memory statistics, called by
zerror.
(show_memory_all) Loop over new mlists array instead of calling
show_memory_vty separately for each memory_list.
|
|
Add 'philosophy' note about balance between modern and being ok for
those tracking stable.
question 4.7-4 as a texinfo version (no such nomenclature on texinfo
site - something specific to some Linux distribution?).
Note that NetBSD provides texinfo 4.6 in the base system.
|
|
* ospf_{apiserver,te}.c: ospf_lsa_free's should be ospf_lsa_unlock.
|
|
* routeserver.texi: Strip ctrl-M from line endings, note by
sigma@smx.pair.com
|
|
* ospf_ia.c: (process_summary_lsa) Only an ABR has any reason to
ignore stub area summary default. Even so it seems a strange
check, add a comment to that effect.
|
|
* INSTALL.quagga.txt: Some quagga specific INSTALL notes.
* README: s/GNU Zebra/Quagga/ and refer to IS-IS support.
|
|
* INSTALL: update-autotools, autoreconf -i will install this, remove
the file so it always matches the autoconf which created
configure (ie the quagga snapshot producing host).
|
|
|
|
* configure.ac: Fix AC_CONFIG_FILES, the chmod seems to run for
every input file, should be only be for vtysh/extract.pl, so that
should be a seperate AC_CONFIG_FILES.
|
|
* vtysh.c: (vtysh_client_execute) Fix flaws in detecting trailing
'\0' chars and command return code.
|
|
* redhat/quagga.spec.in: add comments showing how to get gcc verbosity
|
|
|
|
* bgp_nexthop.c: collapse bgp_connected_ipvX, bgp_nexthop_cache_ipvX
and cache{1,2}.. into arrays of tables and hence collapse
bgp_scan_ipv{4,6} into a single bgp_scan function. Tested, though
a long time ago (and this change was hand-merged).
|
|
* configure.ac: bump version to 0.97.3, release imminent.
|
|
|
|
|
|
* Makefile.am: Add routeserver.texi to quagga_TEXINFOS.
Add quagga.info to clean files list (would have thought automake
would have done this, but it doesnt seem to)
|
|
* buffer.c: Add missing include of log.h.
(buffer_flush_available) written is compared against
mostly against unsigned types, only for the writev do we need
signed compare, so declare it as size_t and cast it to ssize_t
just for the error compare when we've called writev.
* buffer.h: Add comment that buffer data sizes really should be
size_t.
|
|
* quagga.texi: include routeserver.texi. TODO: integrate the current
multiple-instance orientated bgpd route-server section with the
new route-server docs.
|
|
|
|
* configure.ac: Arguments to AC_OUTPUT is deprecated, use
AC_CONFIG_FILES instead. Rearrange the order slightly to put the
Makefiles first (silly aesthetic thing, dont know why I had to do
this ;) ). Add doc/defines.texi to the list.
* NEWS: bgp route-server support added, refer to docs.
* update-autotools: call automake with --add-missing and --copy,
former is important for obvious reasons, latter for dist files,
and --gnu to enable whatever extra goodness checks.
* {depcomp, install-sh, missing}: removed, auto-generated files.
|
|
* lib/version.h.in: add autoconf configure_input output var
|
|
- Fix with_ipv6 set to 0 build
|
|
* Makefile.am: Add automatic rule to build pdf's from eps figures.
Clean *.pdf. Add rule for quagga.pdf (as the eps.pdf pattern
probably otherwise will override automake's rule for quagga.pdf)
* overview.texi: URL was causing TeX overfull, put on newline.
* quagga.texi: Put the copyright notice into @copying section, as
is proper. Strip trailling space from the main menu lines.
* rip(ng)?d.texi: Minor reformatting.
* Add the route server docs.
* bgpd.texi: remove unneeded page breaks. The 6Bone example
overflows though.
|
|
* Add the route server docs.
* routeserver.texi: new file, texinfo'fied and slightly modified
version of the original TeX from James Luis Rubio.
* fig-*.eps: new files, diagrammes.
|
|
* defines.texi.in: New file, texi variables should be set here,
autoconf substitution is available. Define common AUTHORS,
COPYRIGHT_YEAR and COPYRIGHT_STR vars.
* (global): Make use of makeinfo node pointer auto-creation
to avoid having to fully specify links for nodes, so we only have
to specify current node name - simplifies text slightly.
Remove extraneous newlines which appear to cause extra blank pages
to be added in output.
Update copyright strings which appear in various places to
use the new COPYRIGHT_STR texinfo variable.
Change url to uref, the former need not output an actual
hyperlink depending on version of texinfo, the latter should if
supported by the format (eg PDF).
* texinfo.tex: Update to a more recent version. previous file
was many many years old. This file should possibly be removed
altogether, and allowed to be installed by automake.
* quagga.texi: Make use of automake's version.texi feature to
have VERSION and some other vars auto-defined. include
defines.texi. Change copyright strings to use the COPYRIGHT_STR
variable.
* install.texi: Make the privs section an actual section. Ditto for
the Linux notes.
* overview.texi: Supply URL for Quagga, where format allows. Tidy up
one or two paragraphs slightly.
Update the section on supported platforms.
Remove the ZNOG list stuff, direct reader to the website for
further information on email lists.
* vtysh.texi: Update the integrated config file section. Make the
commands sections so correct PDF indexes are built.
|
|
* HACKING: Expand on ChangeLogs, eg current practice for certain
directories and certain other meta-data is not to maintain a
ChangeLog. Expand on the commit message, IMHO, commit message
should always be ChangeLog for files where ChangeLog is kept.
Solaris is supported on any platform (with, at moment, an
additional patch).
|
|
* ospf6_flood.c: When adding a thread to retransmit an lsa after
rxmt_interval, the ospf6d used thread_add_event(). However,
thread_add_event() executes immediately and ignores the delay parameter.
This was causing unnecesary unicast LSU sends. Adding the thread has
been changed to use thread_add_timer() which will expire after delay.
After the fix results appear consistent with expectation.
|
|
|
|
Spelling fixes.
Add Solaris on 64-bit to list of 'supported' platforms.
List NetBSD/sparc64 as a 'future' platform - there aren't enough users
to make it really supported, but it's good at exposing latent bugs
(e.g router advertisement formatting on BSD, and LSA alignment
issues).
Note explicitly that ospf6d and isisd are in 'testing' rather than
'stable'. (Feel free to correct - just wanted to get more explicit.)
Add note questioning current relevance of isisd.sf.net - is our repo
the canonical place now?
|
|
|
|
* vty.h: Remove fields in struct vty that were related to VTY_CONTINUE
capabilities (that were used only in bgpd/bgp_route.c and are now
removed). Also remove some other fields that were not being
used at all.
* vty.c: (vty_execute) Do not test for obsolete status values VTY_START
and VTY_CONTINUE.
(vty_read) Remove calls to vty->output_func since that was part
of the VTY_CONTINUE infrastructure that has been removed.
(vty_flush) Remove code to support VTY_START and VTY_CONTINUE.
(vty_close) Remove code to cancel vty->t_output thread, since that
thread was never actually used.
* bgp_route.c: Remove all code related to VTY_CONTINUE; this feature
is deprecated because the output did not represent a single point
in time. All output needs to be generated inline and buffered
by the library code.
(route_vty_out,route_vty_out_tag,damp_route_vty_out,
flap_route_vty_out) Remove code to count number of lines of output,
since this was only useful for VTY_CONTINUE behavior.
(bgp_show_callback) Removed.
(bgp_show_table) Remove hooks for VTY_CONTINUE callback support.
As a result, there's a new output_arg argument to this function.
Make function static.
(bgp_show) Make function static and add a new output_arg argument.
Change all functions that call bgp_show or bgp_show_table to
pass the new output_arg argument (that used to be passed inside
vty->output_arg).
* bgp_mplsvpn.c: Remove declarations of functions defined in
bgp_route.c; these declarations belong in bgp_route.h.
* bgp_route.h: Declare 3 global functions used in both bgp_route.c
and in bgp_mplsvpn.c.
|
|
* ospfd.c: (ospf_network_match_iface) revert to previous network
statement match behaviour.
|
|
* vty.c: Vtysh connections to daemons should use buffering.
(vty_out) Remove exception for vty_shell_serv, just use buffer_write.
(vty_new) Increase output buffer size to 4096 rounded up to a
multiple of pagesize.
(vtysh_read) After command has been executed and all output buffered,
call buffer_flush_available and schedule further writes if the
buffers are not yet empty.
(vtysh_write) New function to flush output to vtysh when the socket
is writeable.
(vty_event) Added new VTYSH_WRITE event for flushing buffers to vtysh
clients. Also, should save read thread in vty->t_read so the
thread can be cancelled in vty_close.
* buffer.h: In struct buffer_data, remove unused "parent" field.
Convert "unsigned char *data" to "unsigned char data[0]" to save
a malloc. Declare new function buffer_flush_available that works
with non-blocking sockets.
* buffer.c: (buffer_data_new) Use a single malloc now that data is
a variable-size array at end of structure.
(buffer_data_free) Just a single free now that data is part of the
structure.
(buffer_write) Simplify the logic to make behavior more transparent.
(buffer_flush) Decrease b->length as data is written out.
(buffer_flush_vty_all) Decrease b->length as buffers are freed.
(buffer_flush_vty) Decrease b->length as data is written out.
(buffer_flush_available) New function to flush non-blocking sockets.
|
|
* ospf_packet.c: (ospf_write_frags) remove iov arg, msg already points
to it. Add convenience pointer to msg->msg_iov[1], and use this,
fixing the unfortunate borkenness introduced in moving of this code
to a function.
(ospf_write) remove iovp and fix up call to previous.
(ospf_ls_upd_packet_new) cast size to long int - unfortunately
glibc's size_t format modifier is not portable.
|
|
with CVS trees.
|
|
* sockopt.c: (setsockopt_pktinfo) remove, its unused.
|
|
* {bgpd,bgp_attr}.c: size_t printf format should be ld.
|
|
* ospf_packet.c: (ospf_ls_upd_packet_new) Format for size_t should
be ld.
* ospf_zebra.c: (ospf_distribute_list_update_timer) Ugly misuse of
THREAD_ARG to store an integer, but it should at least use same
same type to retrieve the value. Assert value is sane.
|
|
* thread.c: Use XCALLOC and sizeof the type, not the pointer.
|
|
* smux.c: fix int to size_t compile warnings
|
|
* memory.h: Add MTYPE_THREAD_FUNCNAME and MTYPE_THREAD_STATS
* thread.c: Update stats and funcname alloc/free to use previous
specific memory type defines
|
|
* keychain.c: Convert some more strtoul users to VTY_GET_INTEGER.
|
|
* ospf_packet.c: (ospf_write_frags) Add debug output
(ospf_write) set type early, so we can pass it to
ospf_write_frags.
(ospf_ls_upd_packet_new) print size in debug output when too large
packet is encountered.
|
|
|
|
* vty.c: As per Andrew's suggestions..
(vty_serv_un) remove flags.
(vtysh_accept) close socket if we cant set NONBLOCK. Add flags.
|
|
* vty.c: Move setting of sock to O_NONBLOCK from vty_serv_un
to vtysh_accept, where sock is the actual fd we wanted to set to
O_NONBLOCK, ie the /connected/ vtysh unix socket.
|
