summaryrefslogtreecommitdiff
path: root/HACKING
AgeCommit message (Collapse)Author
2008-07-22[bgpd] Fix triggerable crash when compiled with --disable-bgp-announcePaul Jakma
2008-07-22 Paul Jakma <paul.jakma@sun.com> * HACKING: Document preference for compiler conditional code, over cpp conditional. * configure.ac: DISABLE_BGP_ANNOUNCE always should be defined. * bgp_{packet,route,advertise}.c: change to compiler testing of DISABLE_BGP_ANNOUNCE, rather than cpp. 2008-07-22 MIYAJIMA Mitsuharu <miyajima.mitsuharu@anchor.jp> * bgp_packet.c: (bgp_update_packet_eor) Fix crash triggerable if a bgpd was compiled with --disable-bgp-announce and if GR is advertised by peer.
2005-11-102005-11-10 Paul Jakma <paul.jakma@sun.com>paul
* HACKING: Add recommendation to provide a single Subject style description to the commit message. Add some recommendations for ChangeLog.
2005-04-252005-04-25 Paul Jakma <paul.jakma@sun.com>paul
* HACKING: Add some notes about build system changes, to document common oversights (common for me anyway). Seperate sections with two newlines, easier to read.
2005-04-072005-04-07 Paul Jakma <paul.jakma@sun.com>paul
* (global): Fix up list loops to match changes in lib/linklist, and some basic auditing of usage. * configure.ac: define QUAGGA_NO_DEPRECATED_INTERFACES * HACKING: Add notes about deprecating interfaces and commands. * lib/linklist.h: Add usage comments. Rename getdata macro to listgetdata. Rename nextnode to listnextnode and fix its odd behaviour to be less dangerous. Make listgetdata macro assert node is not null, NULL list entries should be bug condition. ALL_LIST_ELEMENTS, new macro, forward-referencing macro for use with for loop, Suggested by Jim Carlson of Sun. Add ALL_LIST_ELEMENTS_RO for cases which obviously do not need the "safety" of previous macro. LISTNODE_ADD and DELETE macros renamed to ATTACH, DETACH, to distinguish from the similarly named functions, and reflect their effect better. Add a QUAGGA_NO_DEPRECATED_INTERFACES define guarded section with the old defines which were modified above, for backwards compatibility - guarded to prevent Quagga using it.. * lib/linklist.c: fix up for linklist.h changes. * ospf6d/ospf6_abr.c: (ospf6_abr_examin_brouter) change to a single scan of the area list, rather than scanning all areas first for INTER_ROUTER and then again for INTER_NETWORK. According to 16.2, the scan should be area specific anyway, and further ospf6d does not seem to implement 16.3 anyway.
2005-04-052005-04-05 Paul Jakma <paul@dishone.st>paul
* HACKING: Expand on the importance of supplying good ChangeLog's in the PATCH SUBMISSION section.
2005-04-052005-04-05 Paul Jakma <paul@dishone.st>paul
* HACKING: remove the 'manually patch redhat/quagga.spec' bit from RELEASE section. Let the rpm revision be CONFDATE, will work fine.
2005-02-23add release procedure, noting redhat spec oddnessgdt
2005-02-23Added -p to the recommended diff flags.hasso
2004-12-222004-12-21 Andrew J. Schorr <ajschorr@alumni.princeton.edu>ajs
* NEWS: Note addition of watchquagga. * HACKING: Note that watchquagga is in testing phase.
2004-12-032004-12-03 Andrew J. Schorr <ajschorr@alumni.princeton.edu>ajs
* HACKING: Indicate that header files should be consulted for documentation, particularly logging levels in lib/log.h. * log.h: Document appropriate use of syslog logging priorities inside quagga.
2004-11-15Note that <dollar>Id:$ should be included in all files.gdt
2004-11-15Make explicit that bumping required tool versions needs thought.gdt
2004-11-052004-11-05 Paul Jakma <paul@dishone.st>paul
* HACKING: Expand on ChangeLogs, eg current practice for certain directories and certain other meta-data is not to maintain a ChangeLog. Expand on the commit message, IMHO, commit message should always be ChangeLog for files where ChangeLog is kept. Solaris is supported on any platform (with, at moment, an additional patch).
2004-11-05Adjust per-directory vs global ChangeLog to match current practice.gdt
Spelling fixes. Add Solaris on 64-bit to list of 'supported' platforms. List NetBSD/sparc64 as a 'future' platform - there aren't enough users to make it really supported, but it's good at exposing latent bugs (e.g router advertisement formatting on BSD, and LSA alignment issues). Note explicitly that ospf6d and isisd are in 'testing' rather than 'stable'. (Feel free to correct - just wanted to get more explicit.) Add note questioning current relevance of isisd.sf.net - is our repo the canonical place now?
2004-09-01Indentation consensus.hasso
2004-07-23(somewhat unrelated cleanups, but all are very minor)gdt
2004-07-23 Greg Troxel <gdt@poblano.ir.bbn.com> * */Makefile.am: Use ../dir/libfoo.la, rather than "-L../dir -lfoo", to avoid linking against installed libraries from a previous version. * {lib,ospfd,ospfclient}/Makefile.am: explicitly define the shared library version number to be 0.0 * configure.ac: remove spurious , so extract.pl is chmod'd +x. * HACKING: explain shared library versioning rules
2004-05-132004-05-13 Paul Jakma <paul@dishone.st>paul
* HACKING: Add comment about updating ChangeLogs (which this commit, ironically, hasnt neglected to do).
2004-01-092004-01-09 Paul Jakma <paul@dishone.st>paul
* HACKING: slight changes to make consistent with devel.php on web site. remove 'not yet consensus' as lack of any disagreement can be interpreted that file does reflect such.
2004-01-05move changelog section up higher.gdt
Add notion of commenting for reviewers and taking care to not break platforms one cannot test on.
2003-12-23Merge isisd into the Quagga's framework:jardin
- add privs support - use misc quagga's definitions - make it compile"able" - fix segfault cases related to hostname() - add debug isis xxx command This patch has been approved by Paul Jakma.
2003-12-22add question about changelog usagegdt
2003-12-19rough cut at committing guidelinesgdt