summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDmitry Tejblum <tejblum@yandex-team.ru>2009-06-23 17:16:32 +0400
committerDenis Ovsienko <pilot@etcnet.org>2009-06-23 17:16:32 +0400
commit774eb1524c3a1e0a9567e6aff3315b4686ab3e75 (patch)
tree56cb71fbc9ec910e079b7bc7bbee47fafeb2d11c
parent5bc52c76c2816a3be9a033c3e5bf4fea1908e3cd (diff)
[ospfd] cancel OSPF timer hack in nsm_change_state
This piece of code causes all Quagga routers on a broadcast link to send a HELLO packet simultaneously if they see a new neighbor. It also resets the HELLO timer, so all the quagga routers will continue to send HELLO packets simultaneously in the future. This is not good (especially on networks with a lot of Quagga routers connected), and is explicitly discouraged by the OSPF standard, RFC 2328 (chapter 4.4.Timers). I suggest to remove the code snippet, it does not provide much benefit anyway.
-rw-r--r--ospfd/ospf_nsm.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/ospfd/ospf_nsm.c b/ospfd/ospf_nsm.c
index f3ac9eaa..15fff349 100644
--- a/ospfd/ospf_nsm.c
+++ b/ospfd/ospf_nsm.c
@@ -778,14 +778,6 @@ nsm_change_state (struct ospf_neighbor *nbr, int state)
break;
}
- /* Performance hack. Send hello immideately when some neighbor enter
- Init state. This whay we decrease neighbor discovery time. Gleb.*/
- if (state == NSM_Init)
- {
- OSPF_ISM_TIMER_OFF (oi->t_hello);
- OSPF_ISM_TIMER_MSEC_ON (oi->t_hello, ospf_hello_timer, 1);
- }
-
/* Preserve old status? */
}