summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Jakma <paul@quagga.net>2012-03-27 11:54:04 +0100
committerPaul Jakma <paul@quagga.net>2012-03-27 11:54:04 +0100
commitfa5831e85ae9ba7008fb4b4e2d4c7561ae5cb697 (patch)
tree5653d8127ad212e6d251fb078afef50fc262353b
parentfa61e16ddebe10a71d98bcd2eba0f630071ea4a7 (diff)
bgpd: bgp_attr_flags_diagnose shouldn't assert
* bgpd/bgp_attr.c: (bgp_attr_flags_diagnose) debug code for error-handling paths probably shouldn't assert, instead it should just log that there was no problem.
-rw-r--r--bgpd/bgp_attr.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index c21655c0..0d82aba0 100644
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -809,7 +809,14 @@ bgp_attr_flags_diagnose (struct bgp_attr_parser_args *args,
attr_flag_str[i].str);
seen = 1;
}
- assert (seen);
+ if (!seen)
+ {
+ zlog (args->peer->log, LOG_DEBUG,
+ "Strange, %s called for attr %s, but no problem found with flags"
+ " (real flags 0x%x, desired 0x%x)",
+ __func__, LOOKUP (attr_str, attr_code),
+ real_flags, desired_flags);
+ }
}
/* Required flags for attributes. EXTLEN will be masked off when testing,