diff options
author | Paul Jakma <paul.jakma@sun.com> | 2006-07-26 09:37:26 +0000 |
---|---|---|
committer | Paul Jakma <paul.jakma@sun.com> | 2006-07-26 09:37:26 +0000 |
commit | 1fe6ed38cd0136c514aabae01389653beab27fb9 (patch) | |
tree | 21f10bc3f9c5afffe9f28e5dbf4e6198cfafba5b /ospfd/ospf_lsa.h | |
parent | 3fed4160cd23f1767d8980e8cba10bc3933947d5 (diff) |
[ospfd] Allow ospf_lsa_unlock to NULL out callers' LSA pointers upon free
2006-07-26 Paul Jakma <paul.jakma@sun.com>
* ospf_lsa.{c,h}: (ospf_lsa_unlock) Change to take a double pointer
to the LSA to be 'unlocked', so that, if the LSA is freed, the
callers pointer to the LSA can be NULLed out, allowing any further
use of that pointer to provoke a crash sooner rather than later.
* ospf_*.c: (general) Adjust callers of ospf_lsa_unlock to match
previous. Try annotate 'locking' somewhat to show which 'locks'
are protecting what LSA reference, if not obvious.
* ospf_opaque.c: (ospf_opaque_lsa_install) Trivial: remove useless
goto, replace with return.
* ospf_packet.c: (ospf_make_ls_ack) Trivial: merge two list loops,
the dual-loop predated the delete-safe list-loop macro.
Diffstat (limited to 'ospfd/ospf_lsa.h')
-rw-r--r-- | ospfd/ospf_lsa.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ospfd/ospf_lsa.h b/ospfd/ospf_lsa.h index 9e480dee..8dd054c3 100644 --- a/ospfd/ospf_lsa.h +++ b/ospfd/ospf_lsa.h @@ -245,7 +245,7 @@ extern struct ospf_lsa *ospf_lsa_new (void); extern struct ospf_lsa *ospf_lsa_dup (struct ospf_lsa *); extern void ospf_lsa_free (struct ospf_lsa *); extern struct ospf_lsa *ospf_lsa_lock (struct ospf_lsa *); -extern void ospf_lsa_unlock (struct ospf_lsa *); +extern void ospf_lsa_unlock (struct ospf_lsa **); extern void ospf_lsa_discard (struct ospf_lsa *); extern struct lsa_header *ospf_lsa_data_new (size_t); |